Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ce/connect messaging #35364

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Ce/connect messaging #35364

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0043322
add models and rename function
calellowitz Nov 14, 2024
7bc3854
add connect backend
calellowitz Nov 14, 2024
c609f0d
add connectid settings and urls
calellowitz Nov 14, 2024
e4b6deb
add connect messages to scheduling forms
calellowitz Nov 14, 2024
929204d
add necessary auth changes
calellowitz Nov 14, 2024
79154f0
update domain deletion code for new models
calellowitz Nov 14, 2024
460c794
use updated method name
calellowitz Nov 14, 2024
092dbe0
implement survey model
calellowitz Nov 15, 2024
f29ebfc
fix default values
calellowitz Nov 15, 2024
91ce6e6
move content fields to top level of payload
calellowitz Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ssaging/scheduling/migrations/0030_remove_connectmessagesurveycontent_message_and_more.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Generated by Django 4.2.15 on 2024-11-15 03:20

from django.db import migrations, models
import django.utils.timezone

Check failure on line 4 in corehq/messaging/scheduling/migrations/0030_remove_connectmessagesurveycontent_message_and_more.py

View workflow job for this annotation

GitHub Actions / Flake8

corehq/messaging/scheduling/migrations/0030_remove_connectmessagesurveycontent_message_and_more.py#L4 

'django.utils.timezone' imported but unused (F401)


class Migration(migrations.Migration):
Expand All @@ -23,13 +23,13 @@
migrations.AddField(
model_name='connectmessagesurveycontent',
name='expire_after',
field=models.IntegerField(default=django.utils.timezone.now),
field=models.IntegerField(default=1),
preserve_default=False,
),
migrations.AddField(
model_name='connectmessagesurveycontent',
name='form_unique_id',
field=models.CharField(default=1, max_length=126),
field=models.CharField(default="1", max_length=126),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just allow this to be blank? Or does 1 have a meaning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this will be unnecessary once we combine the migrations as you mentioned above, we just needed any value to have a valid migration, even though that table was empty when I made this one, so it is never used.

preserve_default=False,
),
migrations.AddField(
Expand Down
Loading