Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark multimedia export as location safe #35378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jingcheng16
Copy link
Contributor

@jingcheng16 jingcheng16 commented Nov 15, 2024

Product Description

Technical Summary

Ticket: https://dimagi.atlassian.net/browse/SAAS-12925

Location-restricted user is not able to export multimedia because the view to export multimedia doesn't have @location_safe decorator. The view to export multimedia will use ExpandedMobileWorkerFilter to limit its access only to the assigned locations.

Context about @location_safe decorator here.

This ticket is similar to https://dimagi.atlassian.net/browse/HI-208

Feature Flag

No

Safety Assurance

Safety story

Test on staging: setting up a location restricted web user who is able to download multimedia, and the multimedia is only restricted to the location that he have access to.

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@jingcheng16 jingcheng16 marked this pull request as ready for review November 15, 2024 21:38
@mkangia
Copy link
Contributor

mkangia commented Nov 20, 2024

How is multimedia restricted to locations? or how do we find out which multimedia is accessible to a location?
I assume multimedia here is app multimedia, which, I would think of being location independent.

The view to export multimedia will use ExpandedMobileWorkerFilter to limit its access only to the assigned locations.

Is this change yet to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants