Added webpack template tags to bootstrap migration tool #35391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
approved these changes
Nov 19, 2024
| issues.append("This template references a bootstrap 3 webpack entry point. " | ||
| "It should also use js_entry instead of js_entry_b3.") | ||
| if tag == "js_entry": | ||
| issues.append("This template references a bootstrap 3 webpack entry point.") |
There was a problem hiding this comment.
js_entry is BS5, right? Is this message correct?
There was a problem hiding this comment.
yep, webpack uses js_entry for B5 and js_entry_b3 for B3, whereas requirejs uses requirejs_main for B3 and requirejs_main_b5 for B5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This will ensure that
js_entry_b3gets renamed tojs_entrywhen a B3 file is migrated, and it addsjs_entry/js_entry_b3to automated checks for B3/B5 consistency within files.Safety Assurance
Safety story
This is a config change to an internal engineering tool.
Automated test coverage
yes
QA Plan
no
Rollback instructions
Labels & Review