Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checking #35402

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add type checking #35402

wants to merge 2 commits into from

Conversation

kaapstorm
Copy link
Contributor

@kaapstorm kaapstorm commented Nov 19, 2024

Technical Summary

Adds a Github workflow for mypy to check the type hints that already exist in the codebase.

Only modules listed in mypy_modules.txt are checked, and type-checking ignores functions and methods in the module that don't have type hints. (In other words, type hints are treated the same as doctests: Not all functions or methods in a module need to have doctests, and modules that do have doctests need to be added to a test suite for them to be tested.)

Safety Assurance

Safety story

There is only one code change: Fixes a bug, exposed by type checking, when flower_url is not set.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the Risk: High Change affects files that have been flagged as high risk. label Nov 19, 2024
@dimagimon dimagimon removed the Risk: High Change affects files that have been flagged as high risk. label Nov 19, 2024
@kaapstorm kaapstorm added the product/invisible Change has no end-user visible impact label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants