Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Adds a Github workflow for mypy to check the type hints that already exist in the codebase.
Only modules listed in
mypy_modules.txt
are checked, and type-checking ignores functions and methods in the module that don't have type hints. (In other words, type hints are treated the same as doctests: Not all functions or methods in a module need to have doctests, and modules that do have doctests need to be added to a test suite for them to be tested.)Safety Assurance
Safety story
There is only one code change: Fixes a bug, exposed by type checking, when
flower_url
is not set.Rollback instructions
Labels & Review