Simplify restore generation code #35414
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoergel
commented
Nov 21, 2024
| with self.timing_context('RegistrationElementProvider'): | ||
| content.append(get_registration_element(self.restore_state.restore_user)) | ||
|
|
||
| with self.timing_context('FixtureElementProvider'): |
There was a problem hiding this comment.
I pull most of this out in the next commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
No user-facing changes, just a pure refactor. I started doing this as part of #35387, but pulled it out to stop from getting distracted. Essentially, there's a lot of OOP boilerplate around fixture generation that is in my opinion more confusing than helpful. Much of it is just wrappers around single-line function calls anyways. This PR moves a lot of things in-line.
I'd like to also make the
FixtureProviderspattern just a simple function call too, but that's for another day.Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review