Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Jira Ticket
Code Scan alert
This PR swaps out
lxml.fromString
todefusedxml.minidom.parseString
to mitigate risks of an XXE attack.Safety Assurance
Safety story
Manually tested in shell using the example xml string
'<bspostevent><field name="MobileNumber" type="string">000000000</field><field name="Text" type="string">sample text</field></bspostevent>'
and verified it returns the same names, numbers and text.QA Plan
I don't have a way of testing this locally so I think it's a good idea to ask QA to take a quick pass on it.
Rollback instructions
Labels & Review