Add HTMX loading styles and related documentation in styleguide #35419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need for an additional htmx-loading class
biyeun
requested review from
mjriley,
orangejenny,
esoergel,
jingcheng16 and
nospame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This PR adds new styles for HTMX loading states of:
Documentation has been added to the HTMX and Alpine styleguide page which demos those common examples, and points out
hx-indicatorandhx-disabled-eltattributes to help with creating good loading states for the user.Safety Assurance
Safety story
Change to docs and to styling. very safe change
Automated test coverage
no
QA Plan
Not needed
Rollback instructions
Labels & Review