-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gsheets related code #35436
Remove gsheets related code #35436
Conversation
Checked on production, the deleted sql model don't have any data. So no need to run migration before deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like another make requirements
is needed to fix tests.
diff --git a/requirements/dev-requirements.txt b/requirements/dev-requirements.txt
index eea7e9f..2656028 100644
--- a/requirements/dev-requirements.txt
+++ b/requirements/dev-requirements.txt
@@ -294,7 +294,6 @@ gnureadline==8.1.2
google-api-core==2.11.0
# via
# firebase-admin
- # google-api-core
# google-api-python-client
# google-cloud-core
# google-cloud-firestore
Otherwise this looks good to me.
@millerdev Weird, I just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed last two commits
Product Description
Technical Summary
We no longer plan to develop gsheet feature. So in this PR I remove all the related code.
Ticket: https://dimagi.atlassian.net/browse/SAAS-16161
Feature Flag
Safety Assurance
Safety story
The deleted code are not referenced anywhere
Automated test coverage
QA Plan
No
Migrations
Rollback instructions
I didn't write reverse code in migration because I don't expect this PR to be reverted
Labels & Review