Add encoding to utfbom reader structure #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I note that we may lost the original encoding if we wrap the
*utfbom.Reader
again.This will ensure that we will return the original encoding instead
Unknown
Also, I made some modifications to code and tests to ensure better readability. for instance, now all tests are running in parallel, all tests may have subtests, we stop use deprecated libraries such as
io/ioutil
, etc.I also add one basic
Makefile
to help run tests, etc.And drop support/ tests for old versions of go -- we are in the 1.21.1 right now
Regards