-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D Terrain components #164
Conversation
… FullscreenControl
…d TerrainControl seems to add/connect the terrain source to the map when clicked (on startup, terrain is not available), perhaps will need "Terrain" component within terrain raster-dem source which does the "style: {terrain:}" bit
…e because MapLibre does not have "removeTerrain", only a setter and getter
…demo of 3D Terrain; add modifiable elements to that page for hillshade and terrain settings
🦋 Changeset detectedLatest commit: c5c4d89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@larsmaxfield is attempting to deploy a commit to the Daniel Imfeld's projects Team on Vercel. A member of the Team first needs to authorize it. |
I see that |
Yeah, please remove the package-lock.json file. I use I'll try to set aside some time to look at this in a day or two, but first glance looks good. Thanks! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Done!
I'll take a look at using this as well in the future.
You're welcome — and thank you! |
This is great. Thanks for contributing! |
I've added components to achieve 3D terrain and hillshading as demoed on MapLibre's 3D Terrain page:
I've added a corresponding demo to Examples. This reflects the original 3D Terrain page from MapLibre with some added modifiable items:
This has not been tested, and I have not added a changeset which I see here is requested. I'm not sure how to do either — but I'd like to learn, if possible.*This has not been tested.Lastly, let me know if there's anything you'd like me to explain or justify. I'm new to Svelte and web development in general, so I may have goofed up (or completely missed) a best practice.
Resolves #163