Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoJSON so it reactively updates on style.load #75

Conversation

mhrgoldberg
Copy link
Contributor

@mhrgoldberg mhrgoldberg commented Oct 4, 2023

Fix GeoJSON component to update reference of sourceObj on the style.load event. Update the example to show this functionality.

reactive.mov

closes #74

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: 272553a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-maplibre Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 4, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @dimfeld on Vercel.

@dimfeld first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-maplibre ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 1:23am

@dimfeld
Copy link
Owner

dimfeld commented Oct 4, 2023

Thanks for the type cleanup in GeoJSON.svelte also!

@dimfeld dimfeld merged commit accb09d into dimfeld:master Oct 4, 2023
@mhrgoldberg mhrgoldberg deleted the mitchellgoldberg/fix-geojson-reactivity-when-baselayer-changes branch October 4, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After baselayer switch GeoJSON source data cannot be updated
2 participants