-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmark #577
base: master
Are you sure you want to change the base?
Fix benchmark #577
Conversation
@@ -14,6 +14,11 @@ use bevy_rapier3d::plugin::RapierContext; | |||
pub fn custom_bencher(steps: usize, setup: impl Fn(&mut App)) { | |||
let mut app = default_app(); | |||
setup(&mut app); | |||
#[cfg(feature = "visual")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add explaination to readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need the README update for the visual
feature, but looking good overall. Thanks!
bevy = { version = "0.14", default-features = false } | ||
rapier3d = { features = ["profiler"], version = "0.22" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminds me that I’d like to revisit that profiler
thing in rapier
to switch so something less manual. Like switching the tracy
or something. (This is unrelated to this PR though.)
Related to #553
Transform
wasn't enough to place correctly the cubes, which made the scene having way too many exploding collisions, which was the main source of bad performance detected in Added initial benchmarks #551.bevy_winit
doesn´t support window recreaction.