-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syn to 2.0
#1342
Update syn to 2.0
#1342
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Ah great, now it failed due to a different spurious and unrelated problem 😅 Edit: seems the previous failure was not spurious and was fixed by 7866bce? |
Friendly ping? Would be nice to get this merged (and ideally, released) to reduce compile-times for downstream projects. |
I agree. However, if I run |
Actually, I realized that I hadn't updated dependencies in my dev environment for a while. After running |
@sebcrozet: it's unclear to me how to handle this correctly with respect to release. I think we need to:
However, as far as I can tell, we don't actually need a new |
Yes, that sounds correct. I think that means you don't even need to change nalgebra to bump the nalgebra-macros dependency. |
Resolves #1403 (I forgot to check PRs before opening an issue ^^) |
Thank you all for making/reviewing this PR! |
Requires no adaptations.