-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bevy 0.11 - fix compile errors #540
Conversation
src_testbed/lines/render_dim.rs
Outdated
} | ||
|
||
let vertex_buffer_layout = layout.get_layout(&[ | ||
Mesh::ATTRIBUTE_POSITION.at_shader_location(0), | ||
Mesh::ATTRIBUTE_COLOR.at_shader_location(1), | ||
])?; | ||
let (label, blend, depth_write_enabled); | ||
if key.contains(MeshPipelineKey::TRANSPARENT_MAIN_PASS) { | ||
if key.contains(MeshPipelineKey::BLEND_ALPHA) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct? i don't know how this system works or what the enums mean. this is also not mentioned in the bevy upgrade notes 0.9-0.10-0.11
So does this fix the testbed examples to not freeze also? What is holding it back from getting merged? |
Tried it and it does fix the testbed. Nice. Hope it gets merged soon. Right now seems the build is failing because of some unused variables. |
ah, unused warnings - i can fix those sure thing @sebcrozet thanks for the push - I didn't connect the new Gizmos API being the replacement for Debug Lines, even through I used both |
Thanks @johnny-smitherson! |
see issue #541
compiles then panics
feel free to take over the upgrade, i usually only login on weekends