Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace lints to control unexpected_cfgs. #682

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

waywardmonkeys
Copy link
Contributor

By using workspace.lints, we can configure lints once for everything (and then inherit it into the various crates).

The lint configuration for unexpected_cfgs works in 1.80+ and warns otherwise.

@waywardmonkeys
Copy link
Contributor Author

waywardmonkeys commented Jul 12, 2024

I've marked this as a draft as there are unexpected cfgs still that need to be resolved:

This will generate a warning from cargo in Rust 1.79 and earlier (1.80 is due for release soon) and there are already 2 warnings from cargo that are more verbose than this one.

I think this replaces #638 from @Urgau

To answer one of the concerns from @sebcrozet , advantages of this PR is that we get the benefit of the unexpected_cfgs lint again and we can start to use workspace.lints to centralize some other lint configurations in the future.

@waywardmonkeys waywardmonkeys force-pushed the warn-on-unexpected-cfgs branch from b15a847 to 937541c Compare July 19, 2024 17:13
@waywardmonkeys waywardmonkeys marked this pull request as ready for review July 19, 2024 17:15
@waywardmonkeys
Copy link
Contributor Author

Now that #684 has landed, I've dealt with the other-backends question in here and this should be ready now.

I've confirmed that it builds without warnings on beta builds (warnings from unexpected_cfgs).

By using `workspace.lints`, we can configure lints once for
everything (and then inherit it into the various crates).

The lint configuration for `unexpected_cfgs` works in 1.80+
and warns otherwise.
@waywardmonkeys waywardmonkeys force-pushed the warn-on-unexpected-cfgs branch from 937541c to b47e932 Compare July 21, 2024 17:11
@Vrixyz Vrixyz merged commit 617428e into dimforge:master Aug 2, 2024
7 checks passed
@waywardmonkeys waywardmonkeys deleted the warn-on-unexpected-cfgs branch August 2, 2024 14:41
@Vrixyz
Copy link
Contributor

Vrixyz commented Aug 2, 2024

Thanks!

@waywardmonkeys
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants