Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of below and orthogonalization. #700

Merged

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@Vrixyz
Copy link
Contributor

Vrixyz commented Jul 24, 2024

Thanks! Would it make sense to add Bellow` as a forbidden word for the typo check ? it seems unlikely anything in our repo will "make the deep roaring sound characteristic of a bull."

Also would it make sense to make an upstream issue to typos for ortogonalization ?

@waywardmonkeys
Copy link
Contributor Author

Up to you!

Submitting upstream is a matter of commenting on a bug, I think.

@Vrixyz Vrixyz merged commit 35ac662 into dimforge:master Jul 26, 2024
7 checks passed
@Vrixyz
Copy link
Contributor

Vrixyz commented Jul 26, 2024

I filed crate-ci/typos#1051 (comment) as a follow up

@waywardmonkeys waywardmonkeys deleted the fix-spelling-orthogonal-below branch July 26, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants