Fix character controller ground detection attempt 3 #715
+174
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following details from #711 (comment)
predict_ground
functionThe tests were not passing though, a ground of 600 makes the controller not grounded at
By adding more height to the ground, I could make the test pass.
video illustration
Unfortunately we can´t see in the video, but during a frame the charactercontroller is detected as grounded when flying exactly on the edge of the "cliff":
Screencast.from.09-09-2024.04.21.37.PM.webm
It's not the case before because we were not computing the ground state when there was no collision on the initial
cast_shape
.