Implement Logical Decoding compatibility with Postgres 9.6. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several function and column names have changed (xlog to wal) between Postgres major versions 9.6 and 10, and also in Postgres 9.6 creating a logical replication slot seems to always export a (new) snapshot. In this PR we adjust pgcopydb behavior to rely on the logical replication protocol CREATE_REPLICATION_SLOT command to export our snapshot when the option --follow is used and the source server is Postgres 9.6.
Both needed special attention, in particular in the test suite.
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Jun 26, 2024
bbc8961 (PG to PG): Use pgcopydb for initial data copy (dimitri#123) 613e011 Problem: Table data filtering is not working on PG to TS (dimitri#122) 324f635 Cover case sensitive table data filtering (dimitri#121) 881816f Problem: Vacuum worker exits early after table copy (dimitri#116) 000b3b2 fix: grant with admin and inherit true Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several function and column names have changed (xlog to wal) between Postgres major versions 9.6 and 10, and also in Postgres 9.6 creating a logical replication slot seems to always export a (new) snapshot.
In this PR we adjust pgcopydb behavior to rely on the logical replication protocol CREATE_REPLICATION_SLOT command to export our snapshot when the option --follow is used and the source server is Postgres 9.6.
Fixes #105.