Refrain from removing the version file in make clean. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker build does `make clean install` and we want to keep the version file around in that environment. Have a new `make maintainer-clean` entry to remove the version file.
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Jun 26, 2024
While playing with timescaledb jobs, I saw the following error, > 2024-06-20T07:18:17.916 INFO: unexpected log from '<container-mount>/logs/pgcopydb_follow_stderr_2024-06-20_07-16-37.log 2024-06-20T07:18:17.916 INFO: 2024-06-20 07:18:16.006 1780833 ERROR pgsql.c:2985 [TARGET 2865558] [42501] ERROR: permission denied for table bgw_job 2024-06-20T07:18:17.917 INFO: unexpected log from '<container-mount>/logs/pgcopydb_follow_stderr_2024-06-20_07-16-37.log 2024-06-20T07:18:17.917 INFO: 2024-06-20 07:18:16.006 1780833 ERROR pgsql.c:3000 [TARGET 2865558] Context: Failed to receive pipeline sync Hence adding those additional internal timescale schemas from replications. Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker build does
make clean installand we want to keep the version file around in that environment. Have a newmake maintainer-cleanentry to remove the version file.