Fix COPY partitioning. #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the per-table part count was computed incorrectly, leading to the COPY supervisor adding unknown partitions in the COPY processing queue. Second, we support both PRIMARY KEYS and also UNIQUE indexes without a NOT NULL constraint, which means we should add a partition for the WHERE IS NULL clause.
dimitri
force-pushed
the
fix/copy-partitioning
branch
from
9692008
to
2dfc26c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the per-table part count was computed incorrectly, leading to the COPY supervisor adding unknown partitions in the COPY processing queue.
Second, we support both PRIMARY KEYS and also UNIQUE indexes without a NOT NULL constraint, which means we should add a partition for the WHERE IS NULL clause.
Fixes #755
Fixes #756