-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow identity based sequences to be found and reset #778
Conversation
bd07a84
to
dd43514
Compare
6a16e29
to
2a3be45
Compare
619dc18
to
d03471c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm not sure how to reason about the SQL changes by themselves, so I must admit I'm relying on the test suite here. Speaking of which, see comments.
@dimitri passing again |
Thanks @kbarber ! |
@dimitri goes without saying I guess, but if you get a regression and need me let me know. Thanks for your help on this one, I prefer the unit test area, I'll be sure to populate it some more :-). |
Fixes: #777
I put this up as a fix and a regression test for #777. With some changes to the query I've managed to get it discovering identity + normal sequences: