Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rules for protonmail & add alternative domain names #7

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

hashbangblob
Copy link
Contributor

Protonmail allows email aliases by adding a plus sign and adding arbitrary text behind it. (see https://proton.me/support/addresses-and-aliases#plus)
However, the current implementation simply replaces the plus sign from the username with an empty string without disposing of text following the plus sign. The proposed change fixes this use case.

Furthermore, there are multiple known domain names used by protonmail (see https://proton.me/support/addresses-and-aliases) but only "protonmail.ch" is handled in the current implementation. The proposed change adds the protonmail normalization rule to the following known alternative domains:

  • protonmail.ch
  • protonmail.com
  • proton.me
  • pm.me

@dimuska139
Copy link
Owner

Thank you!

@dimuska139 dimuska139 merged commit 42af7d0 into dimuska139:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants