Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: differentiate between (+/-) and (-/+) in output #59

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

QuintenBruynseraede
Copy link
Contributor

This PR adds a different suffix for "create-delete" and "delete-create", as defined by Terraform's internal change representation.

"create-delete" becomes suffix (+/-), "delete-create" becomes suffix (-/+). Although I'm unable to reproduce "create-delete" with Terraform itself, I modified a json statefile manually and the output is as expected.

image

Closes issue #42

dineshba
dineshba previously approved these changes Dec 18, 2023
Copy link
Owner

@dineshba dineshba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Really appreciate

@QuintenBruynseraede
Copy link
Contributor Author

QuintenBruynseraede commented Dec 18, 2023

I notice the build failed, possibly because the slices package wasn't available in go 1.20? Should I add a helper function to do the check or can we update to 1.21?

@dineshba
Copy link
Owner

We can update to 1.21 @QuintenBruynseraede

dineshba
dineshba previously approved these changes Dec 22, 2023
Copy link
Owner

@dineshba dineshba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuintenBruynseraede
Copy link
Contributor Author

Thanks @dineshba, fixed the build issues now. Can you trigger another run please?

dineshba
dineshba previously approved these changes Dec 22, 2023
@dineshba dineshba merged commit 5c19269 into dineshba:main Dec 22, 2023
1 check passed
@dineshba dineshba mentioned this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants