Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #20 "unexpected end of JSON input" error #64

Merged
merged 5 commits into from
Jan 27, 2024

Commits on Jan 13, 2024

  1. correct input reading logic

    This addresses #20 and
    ensures input is read from the plan file -- and not via STDIN -- if a
    plan file argument is provided.
    
    This also seeks to improve some of the error messaging to be a bit more
    clear.
    mdb committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    ed100ee View commit details
    Browse the repository at this point in the history
  2. demo issue 20 fix via GH Actions

    Ideally, tf-summarize would feature a suite of automated tests verifying
    its functionality. In absenece of that, this demos the issue #20 fix via
    GH Actions.
    mdb committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    f99306a View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. use consistent TF version when invoking TF

    - ensure the generation of the `example` directory data is done in a
      consistent, reproducible fashion
    - ensure GH Actions uses the same version of TF expected by the `example` directory
    - add plan and plan JSON files to source control, for testing purposes
    mdb committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    40f8d1b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. add automated test verifying STDIN vs file-provided input

    This adds a basic automated test verifying the validity of the issue #20
    fix.
    mdb committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b30b0cb View commit details
    Browse the repository at this point in the history
  2. remove demo job from Build GH Actions workflow

    Per code review request, @dineshba would prefer this be kept in a
    separate file.
    mdb committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7a34e31 View commit details
    Browse the repository at this point in the history