Fix potential null pointer deferenced #363
Conversation
clist_content is a MACRO and return NULL: #define clist_content(iter) (iter ? (iter)->data : NULL)
| @@ -1716,7 +1716,7 @@ static int imap_mailbox_list_to_group(clist * imap_mb_list, clistiter ** iter, | |||
| imap_mailbox_listiter = * iter; | |||
|
|
|||
| imap_addr = clist_content(imap_mailbox_listiter); | |||
| if (imap_addr->ad_mailbox_name == NULL) { | |||
| if (imap_addr != NULL && imap_addr->ad_mailbox_name == NULL) { | |||
There was a problem hiding this comment.
I'm pretty sure having imap_addr == NULL is not a valid use case.
(and it would crash on lines below)
So, there's two options:
Either we test at the beginning of the function and return MAIL_ERROR_INVAL or maybe the code is fine after all and imap_mailbox_list_to_group() is used only with the content of iter not NULL.
There was a problem hiding this comment.
I think you right, better test is:
if (imap_addr == NULL || imap_addr->ad_mailbox_name == NULL) {
What do you think?
| @@ -1739,7 +1739,7 @@ static int imap_mailbox_list_to_group(clist * imap_mb_list, clistiter ** iter, | |||
|
|
|||
| imap_addr = clist_content(cur); | |||
|
|
|||
| if (imap_addr->ad_mailbox_name == NULL) { | |||
| if (imap_addr != NULL && imap_addr->ad_mailbox_name == NULL) { | |||
There was a problem hiding this comment.
Here, cur is guaranteed to be non null via the for loop, so we don't need to do that check.
The only option left is imap_mailbox_listiter containing NULL in the list of mailbox it has.
It probably means that invalid data has been input to that function.
* Fix potential null pointer deferenced clist_content is a MACRO and return NULL: #define clist_content(iter) (iter ? (iter)->data : NULL) * FIx invalid test against NULL.
clist_content is a MACRO and return NULL:
#define clist_content(iter) (iter ? (iter)->data : NULL)