refactor: Add sepearte step for docker logging

dinushchathurya · Jul 10, 2023 · a94745b · a94745b
1 parent 00947f7
commit a94745b
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/.github/workflows/action.yaml b/.github/workflows/action.yaml
@@ -10,9 +10,6 @@ permissions: write-all
 jobs:
   deploy:
     runs-on: ubuntu-latest
-    env:
-      DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
-      DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
     steps:
     - uses: actions/checkout@v3
     - name: Set up JDK 11
@@ -32,8 +29,11 @@ jobs:
       run: ./gradlew test
     - name: Build docker image
       run: ./gradlew --no-daemon jibDockerBuild
-    - name: Execute Gradle dockerPush
-      run: |
-        docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_PASSWORD }} 
-        ./gradlew --no-daemon dockerPush
+    - name: Docker login
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKER_USERNAME }}
+        password: ${{ secrets.DOCKER_PASSWORD }}
+    - name: Push docker image
+      run: ./gradlew --no-daemon dockerPush