Fetch Cairo ABIs from node

[droserasprout]

Currently Starknet indexes require adding ABI JSON manually. Starkscan has ABIs too, but API access is expensive af (we could parse them from webpage like in #1102). In Starknet you can acquire Cairo ABI from Node

[JoE11-y]

Hi @droserasprout is this open, would love to complete it.

[droserasprout]

@JoE11-y We do not participate in any bounty programs at the moment of writing. But carefully crafted pull requests are always welcome.

[JoE11-y]

Alright sounds good though.

…

On Wed, Oct 23, 2024, 1:05 PM Lev Gorodetskii ***@***.***> wrote: @JoE11-y <https://github.com/JoE11-y> We do not participate in any bounty programs at the moment of writing. But carefully crafted pull requests are always welcome. — Reply to this email directly, view it on GitHub <#1108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANGCG5WCJXZRSGJYF65RL5DZ46GITAVCNFSM6AAAAABOQPL3Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRHEYDKOBZGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[baitcode]

@dmirgaleev May I try to implement this?

[droserasprout]

@baitcode You're very welcome! But first let us the team meet after the holidays to discuss release schedule and review your previous submission.

[baitcode]

@droserasprout Any update?

[baitcode]

@droserasprout

I've been researching trying to find vector to start implementing and realised that I don't understand src/dipdup/datasources/abi_etherscan file and comment. Is this one going to be removed? Shall I create abi_starknet and implement logic needed there or shall I just extend abi starknet_starkscan (to fetch and parse pages) and starknet_node to fetch abis.

[droserasprout]

@baitcode Renaming abi.etherscan to evm.etherscan is just about naming, nothing else. We wanted all datasources to match the {network}.{name} schema, making it more obvious that if it starts with evm it can be attached to evm indexes.

For this task you should extend existing datasources. During the codegen phase use the best combination of sources from the inventory or fail with a meaningful message if there's not enough.

[baitcode]

@droserasprout Do I understand correctly, that implementing starkscan datasource is not required (for some reason I though it is).

[baitcode]

@droserasprout If contract abi was configured manually, do I still need to fetch it from node api?
TO rephrase that what has more priority? Node Data or User Data?

[baitcode]

@droserasprout Can you provide any guidance or outline general approach how to test the workflow I've created?

[droserasprout]

@baitcode Currently, ABIs are included in the demo project and simply copied. You need to remove src/dipdup/projects/demo_starknet_events/abi/stark_usdt/cairo_abi.json.j2 file, then run make demos DEMO=demo_starknet_events. If it goes well, tests/test_demos.py will stay green.

[baitcode]

I've been able to figure the test out.

I've installed dipdup from my local repo using installed script with --path argument specified.

[baitcode]

@droserasprout For some reason to make dipdup init work I needed to follow a simlink (the one that points to project itself) one level down. What is the purpose of such linking?

Now everything tested.

[baitcode]

@baitcode Currently, ABIs are included in the demo project and simply copied. You need to remove src/dipdup/projects/demo_starknet_events/abi/stark_usdt/cairo_abi.json.j2 file, then run make demos DEMO=demo_starknet_events. If it goes well, tests/test_demos.py will stay green.

@droserasprout
Done!