Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- remove method return type 'void' which can be used in php7.1 or higher.
  • Loading branch information
vpodorozh committed Oct 27, 2018
1 parent d2e5345 commit 2539a71
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class ImageTest extends \PHPUnit\Framework\TestCase
*/
protected $resourceMock;

protected function setUp(): void
protected function setUp()
{
$this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
$this->connectionMock = $this->createMock(AdapterInterface::class);
Expand Down Expand Up @@ -75,7 +75,7 @@ protected function getVisibleImagesSelectMock(): \PHPUnit_Framework_MockObject_M
* @param int $imagesCount
* @dataProvider dataProvider
*/
public function testGetCountAllProductImages(int $imagesCount): void
public function testGetCountAllProductImages(int $imagesCount)
{
$selectMock = $this->getVisibleImagesSelectMock();
$selectMock->expects($this->exactly(2))
Expand Down Expand Up @@ -113,7 +113,7 @@ public function testGetCountAllProductImages(int $imagesCount): void
* @param int $batchSize
* @dataProvider dataProvider
*/
public function testGetAllProductImages(int $imagesCount, int $batchSize): void
public function testGetAllProductImages(int $imagesCount, int $batchSize)
{
$this->connectionMock->expects($this->once())
->method('select')
Expand Down

0 comments on commit 2539a71

Please sign in to comment.