Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default strategy.type #133

Open
dorkamotorka opened this issue Oct 2, 2023 · 1 comment · May be fixed by #134
Open

Default strategy.type #133

dorkamotorka opened this issue Oct 2, 2023 · 1 comment · May be fixed by #134

Comments

@dorkamotorka
Copy link

Any particular reason, why this is set to Recreate?

uptime-kuma-helm/charts/uptime-kuma/values.yaml

Line 146 in 41f5e05

type: Recreate

In general, the default value should be RollingUpdate to conform with the Kubernetes default values or is there something I don't understand?
@dirsigler
Copy link
Owner

The git blame says it was configured by me. That means it was probably the default value issued when creating a new Helm Chart.
https://github.com/dirsigler/uptime-kuma-helm/blame/41f5e05f97a124db74d4d4e05a32337dcd102df8/charts/uptime-kuma/values.yaml#L146
But you are right that RollingUpdate is the default value set by Kubernetes itself.

If you want to configure anything else you can open a new PR with changes to set a custom value, else I can also add such change.

@dorkamotorka dorkamotorka linked a pull request Oct 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update default strategy.type value dorkamotorka/uptime-kuma-helm
2 participants
@dirsigler @dorkamotorka