Update default strategy.type value #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirsigler
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Looks good, but could you also please bump the Chart version here: https://github.com/dorkamotorka/uptime-kuma-helm/blob/main/charts/uptime-kuma/Chart.yaml#L14 ?
Thank you!
|
@dirsigler Can you take a look at getting this merged? Code LGTM, but the lining for |
dirsigler
approved these changes
Jan 8, 2024
|
Hey @dorkamotorka and @hollanbm , thank you for your patience. In the meantime the Chart already bumped into higher versions, so the Chart version here needs to be updated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a small change in the default value of the
strategy.type.Benefits
This change syncs with the default value of the Kubernetes deployments.
Applicable issues