Feat/add servicemonitor #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
dirsigler
approved these changes
Jul 30, 2023
|
Crazy good addition. Thanks a lot @nobbs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a
ServiceMonitorresource if the enabled and the cluster supports it. This will instruct a deployed Prometheus instance in the cluster to scrape Uptime Kuma metrics.Benefits
Uptime Kuma metrics automatically show up in Prometheus.
Possible drawbacks
None known.
Applicable issues
Additional information
The
ServiceMonitortemplate will check if the cluster does have themonitoring.coreos.com/v1API capability and only create the object if that check succeeds. This will prevent deployment failure withserviceMonitor.enabled: truein clusters missing the Prometheus monitoring stack.Checklist
Chart.yamlaccording to semver.