style: refactor deployment and statefulset to be more similar #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves "podLabels not included when useDeploy is true dirsigler#114" Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
nobbs
force-pushed
the
chore/sync-deploy-and-statefulset-manifest
branch
from
782b27c
to
7a9f101
Compare
dirsigler
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
"Sync" the manifest templates for
DeploymentandStatefulSetso that the available options like enabling / disabling probes, additional pod labels etc. are used in both resource types.Benefits
Possible drawbacks
Applicable issues
Additional information
Not sure if this warrants a version bump. The change does potentially change the final deployment / statefulset manifest depending on the values used 🤷🏻
Checklist
Chart.yamlaccording to semver.