Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: liveness probe command #166

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

atobaum
Copy link
Contributor

@atobaum atobaum commented Jun 13, 2024

Description of the change
Added node to liveness probe.

Context
Due to node command being omitted in the liveness probe of deployment, the following events are occurring in my k8s cluster:

Name:             uptime-kuma-5b765cc74c-7tfvk.17cb9700282d4285
Namespace:        uptime-kuma-system
Labels:           <none>
Annotations:      <none>
API Version:      v1
Count:            363130
Event Time:       <nil>
First Timestamp:  2024-05-02T06:08:30Z
Involved Object:
  API Version:       v1
  Field Path:        spec.containers{uptime-kuma}
  Kind:              Pod
  Name:              uptime-kuma-5b765cc74c-7tfvk
  Namespace:         uptime-kuma-system
  Resource Version:  42515422
  UID:               d2200d3b-0bfd-42d3-a8d2-d6917ae31d03
Kind:                Event
Last Timestamp:      2024-06-13T06:56:48Z
Message:             (combined from similar events): Liveness probe errored: rpc error: code = Unknown desc = failed to exec in container: failed to start exec "bb64cb3256790c20687b7b119ed4dac6fa5705bc736d691628d6f8acc937e917": OCI runtime exec failed: exec failed: unable to start container process: exec: "extra/healthcheck": stat extra/healthcheck: no such file or directory: unknown
Metadata:
  Creation Timestamp:  2024-05-02T06:08:30Z
  Resource Version:    98857066
  UID:                 48cd7e56-ec26-4289-ac4b-9730a9572a4c
Reason:                Unhealthy
Reporting Component:   
Reporting Instance:    
Source:
  Component:  kubelet
  Host:       standard-nodes-w-1rrt
Type:         Warning
Events:       <none>

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md

@atobaum atobaum marked this pull request as ready for review June 13, 2024 07:18
@atobaum atobaum requested a review from dirsigler as a code owner June 13, 2024 07:18
@dirsigler dirsigler assigned dirsigler and unassigned dirsigler Jun 21, 2024
@dirsigler dirsigler added the bug Something isn't working label Jun 21, 2024
Copy link
Owner

@dirsigler dirsigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bump the Chart Version. Would recommend 2.19.0.
You can also run helm-docs afterwards to update the README.md

@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: "1.23.13"
appVersion: "1.23.14"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appVersion reflects the version of the UptimeKuma Image used. So please keep it at 1.23.13.

Copy link
Contributor Author

@atobaum atobaum Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your comments. thank you.

@atobaum atobaum requested a review from dirsigler June 25, 2024 00:16
Copy link
Owner

@dirsigler dirsigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirsigler
Copy link
Owner

Thank you very much @atobaum for the work! ❤️

@dirsigler dirsigler merged commit e4c1049 into dirsigler:main Jun 25, 2024
4 checks passed
@atobaum atobaum deleted the fix/liveness-check branch June 26, 2024 01:29
@dirsigler
Copy link
Owner

Just as an FYI @atobaum , I "reverted" the change again due to the "node" command being deprecated (see this code ).

But now I also provided the functionality to configure the livenessProbe as desired, so if you encounter any issues and still need to use the "node" command, you can add it to your release values.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants