-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: liveness probe command #166
Conversation
c8d34ce
to
63a3f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also bump the Chart Version. Would recommend 2.19.0
.
You can also run helm-docs afterwards to update the README.md
charts/uptime-kuma/Chart.yaml
Outdated
@@ -1,5 +1,5 @@ | |||
apiVersion: v2 | |||
appVersion: "1.23.13" | |||
appVersion: "1.23.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion
reflects the version of the UptimeKuma Image used. So please keep it at 1.23.13
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied your comments. thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you very much @atobaum for the work! ❤️ |
Just as an FYI @atobaum , I "reverted" the change again due to the "node" command being deprecated (see this code ). But now I also provided the functionality to configure the livenessProbe as desired, so if you encounter any issues and still need to use the "node" command, you can add it to your release |
Description of the change
Added
node
to liveness probe.Context
Due to
node
command being omitted in the liveness probe of deployment, the following events are occurring in my k8s cluster:Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.