Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing UPTIME_KUMA_PORT value when applying with serverSide enabled #183

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix parsing UPTIME_KUMA_PORT value when applying with serverSide enabled #183

merged 1 commit into from
Dec 13, 2024

Conversation

ebarped
Copy link
Contributor

@ebarped ebarped commented Dec 13, 2024 •
edited
Loading

Fixes #184

I tested it getting the manifests.yaml with the default values but setting useDeploy: false

before:

  • kubectl apply -f manifests.yaml --dry-run=server
Error from server (BadRequest): error when creating "manifests.yaml": StatefulSet in version "v1" cannot be handled as a StatefulSet: json: cannot unmarshal number into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

after:

  • kubectl apply -f manifests.yaml --dry-run=server
statefulset.apps/test-uptime-kuma created (server dry run)

@ebarped ebarped requested a review from dirsigler as a code owner December 13, 2024 10:46
@ebarped ebarped mentioned this pull request Dec 13, 2024
Closed
@dirsigler dirsigler merged commit 3c2fa79 into dirsigler:main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirsigler dirsigler dirsigler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[server-side apply] error parsing UPTIME_KUMA_PORT on StatefulSet
2 participants
@ebarped @dirsigler