Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

don't let anything download files into the repo #9

Open
onlyjsmith opened this issue Mar 9, 2019 · 3 comments
Open

don't let anything download files into the repo #9

onlyjsmith opened this issue Mar 9, 2019 · 3 comments
Labels
all-fns Relevant to all functions

Comments

@onlyjsmith
Copy link
Member

I think this line, and maybe others, downloads external files into the folder where the code is.

This is bad!

We need to make use of the tempdir and tempfile commands to write to locations outside the code repo.

There's a closely-related issue about caching, which I'll open separate issue on.
@onlyjsmith
Copy link
Member Author

https://rdrr.io/r/base/tempfile.html is a place to start

@onlyjsmith onlyjsmith added the all-fns Relevant to all functions label Mar 9, 2019
@onlyjsmith
Copy link
Member Author

onlyjsmith commented Mar 9, 2019 •
edited
Loading

See also disarm-platform/algorithms-issues#1

@HughSt
Copy link
Contributor

HughSt commented Jan 23, 2020

Related to #5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
all-fns Relevant to all functions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onlyjsmith @HughSt