Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades #1819

Merged
merged 19 commits into from
Apr 18, 2022
Merged

Conversation

Alf-Melmac
Copy link
Contributor

@Alf-Melmac Alf-Melmac commented Sep 14, 2021

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.
  • I have read the [contributing guidelines][contributing].

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: Gradle and Dependency updates

Description

Jar sizes before and after updates (in KB) (Build date: 03.11.2021)

Jar Before After Factor
DEV 1440 1440 1
DEV-javadoc 2983 2983 1
DEV-sources 1235 1235 1
DEV-withDependencies 10369 12530 1.2
DEV-withDependencies-min 4624 6409 1.4
DEV-withDependencies-no-opus 7066 9227 1.3

Dependency Upgrades

Dependency with changelog Old version New version Comment
com.github.johnrengelman.shadow 5.1.0 7.1.2 Required Gradle 7.0+
org.jetbrains:annotations 16.0.1 23.0.0
org.slf4j:slf4j-api 1.7.25 1.7.36
com.squareup.okhttp3:okhttp 3.13.0 4.9.3
org.apache.commons:commons-collections4 4.1 4.4
org.junit.jupiter:junit-jupiter 5.4.0 5.8.2
Gradle 7.3.3 7.4.2 Update from 6.8.3 -> 7.3.3 already done in #1976
com.fasterxml.jackson.core:jackson-core - 2.13.2
com.fasterxml.jackson.core:jackson-databind 2.10.1 2.13.2.2

Gradle update to 7.2 as 7+ is required by updated dependencies
@Alf-Melmac
Copy link
Contributor Author

This needs some more testing. So far everything looks good, there have been no breaking changes, Gradle excluded, that affect us.

@ghost
Copy link

ghost commented Sep 16, 2021

nitpick: this should also bump the versions at the bottom of the readme

@DV8FromTheWorld
Copy link
Member

Out of curiosity, do we know if it is the upgrade to Okhttp that is spiking our jar sizes?

@Chew
Copy link
Contributor

Chew commented Sep 19, 2021

Definitely a factor...

Okhttp 3.13.0 is 404 KB.
Okhttp 4.9.1 is 779 KB.

Also concerning:
JNA 4.4.0 is 1.0 MB
JNA 5.9.0 is 1.6 MB

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@HeyBanditoz
Copy link

Doesn't OkHttp 4.x pull Kotlin as a dependency also?

@Alf-Melmac
Copy link
Contributor Author

Doesn't OkHttp 4.x pull Kotlin as a dependency also?

According to https://square.github.io/okhttp/upgrading_to_okhttp_4/#gradle , there should be no difference to 3.13.

@duncte123
Copy link
Contributor

Doesn't OkHttp 4.x pull Kotlin as a dependency also?

According to https://square.github.io/okhttp/upgrading_to_okhttp_4/#gradle , there should be no difference to 3.13.

That only talks about minimum requirements. And yes, it does pull Kotlin.

@discord-jda discord-jda deleted a comment from BrooklynDewolf Sep 26, 2021
@Alf-Melmac Alf-Melmac marked this pull request as ready for review November 3, 2021 22:54
@Alf-Melmac Alf-Melmac changed the base branch from v5 to master November 29, 2021 17:45
build.gradle.kts Outdated Show resolved Hide resolved
Added jackson-core
Upgraded jackson-databind
# Conflicts:
#	gradle/wrapper/gradle-wrapper.jar
#	gradlew
Via `gradle wrapper --gradle-version 7.4`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants