Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/small text support #2672

Closed

Conversation

Andre601
Copy link
Contributor

@Andre601 Andre601 commented May 4, 2024

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Adds support for Discord's planned small-text format (-# text) to the MarkdownUtil and MarkdownSanitizer.

I'm sure that I haven't covered everything, so I feel free to point out any missing parts.

This remains a draft until the feature is added and documented by Discord.

@MinnDevelopment
Copy link
Member

I think this is now released, is there anything left to do?

@Andre601
Copy link
Contributor Author

I think this is now released, is there anything left to do?

Mainly a way to sanitize/escape it...
Not sure how to implement this...

@@ -57,6 +57,8 @@ public class MarkdownSanitizer
public static final int QUOTE = 1 << 9;
/** Quote block region such as {@code ">>> text here"} */
public static final int QUOTE_BLOCK = 1 << 10;
/** Small text such as {@code "-# text here"} */
public static final int SMALL_TEXT = 1 << 11;
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is called "subtext". Please update all references to use this naming

@Andre601
Copy link
Contributor Author

Andre601 commented Sep 4, 2024

Can't find motivation in continuing this PR myself. If someone wants to work on it themself, feel free to use (parts of) this PR.

@Andre601 Andre601 closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants