Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LocalizationMapper to enable more checks #2676

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

freya022
Copy link
Contributor

@freya022 freya022 commented May 5, 2024

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: Tests

Closes Issue: NaN

Description

Refactors the localization mapper since we now have the full objects, instead of the raw data.

This enables the checks on options and choices, which wasn't possible before.

Since this now adds the localized strings on the Java objects (instead of JSON), you can read those after pushing the command to Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants