Add premium buttons #2752
Merged
Add premium buttons #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freya022
force-pushed
the
feature/premium-buttons
branch
from
ebc464f
to
54ece60
Compare
Can't use emojis on premium buttons
freya022
force-pushed
the
feature/premium-buttons
branch
from
54ece60
to
9e4071b
Compare
MinnDevelopment
requested changes
Nov 1, 2024
src/main/java/net/dv8tion/jda/api/interactions/callbacks/IPremiumRequiredReplyCallback.java
Outdated
Show resolved
Hide resolved
...ain/java/net/dv8tion/jda/api/requests/restaction/interactions/InteractionCallbackAction.java
Outdated
Show resolved
Hide resolved
...java/net/dv8tion/jda/api/requests/restaction/interactions/PremiumRequiredCallbackAction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/component/ButtonImpl.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/utils/ComponentsUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/utils/ComponentsUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/callbacks/IPremiumRequiredReplyCallback.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/component/ButtonImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/net/dv8tion/jda/test/util/ComponentsUtilTest.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
- Checks validity in common method - Prevents changing emoji/url/id on incompatible types - Support premium styles in general-purpose factories
src/main/java/net/dv8tion/jda/internal/interactions/component/ButtonImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/component/ButtonImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/components/buttons/Button.java
Outdated
Show resolved
Hide resolved
- Moved test constants to constant fields - Added tests for "with" methods Co-authored-by: Florian Spieß <business@minn.dev>
MinnDevelopment
approved these changes
Nov 3, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Implements changes of https://discord.com/developers/docs/change-log#premium-apps-new-premium-button-style-deep-linking-url-schemes.
Deprecated the premium reply callback, which are replaced with premium buttons.