Fix: Update nuget packages. #1569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RheaAyase
reviewed
Sep 15, 2020
|
Is there any update on this? A release with #1571 merged in is getting closer to needing to be released before all stable releases become unusable. The solution of getting the latest nightly from myget is not a solution for those that want only release versions. |
|
I could update this again. |
|
It seems the example, and the analyzer project as well as the test for that analyzer project in this repository needs an update to some packages which I can do as well. |
* Update JetBrains.Annotations to 2020.1.0. * Update Microsoft.CodeAnalysis.CSharp.Scripting to v3.7.0. * Update Microsoft.Extensions.DependencyInjection to v3.1.9. * Update packages on the tests. * Silence annoying warning from samples. The EOL framework warning was annoying as hell so disabled it on all projects.
AraHaan
commented
Nov 2, 2020
|
Well shit looks like the other package breaks it. |
|
There it all seems to work now. |
|
This was added in 3.0 of dnet. ref #1923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to update the nuget packages here as they seem to work well at the moment locally as well anyway. Plus I see no harm in updating the analyzer as well so updated that as well.
Note: I locally use the pre-release packages from the dotnet5 feeds and stuff and as such I had to ensure that I use the latest stables instead on this pull request. Local copy works fine with the dotnet 5 preview packages though.
Fixes #1568
Changes:
TargetFrameworksand instead only reference the nuget package for the .NET Framework reference assemblies with anTargetFrameworkthat is .NET Framework is being compiled, it also makes them able to compile on non-windows os removing the need for the OS check on the project file.TargetFrameworkssince some people would want to target Discord bots to that framework in the future possibly to use updated packages that resolves security issues that dropped support to anything older than .NET 5.0.The reason I added .NET 5.0 support is because I do not know if the .NET 5.0 SDK would recognize Discord.NET as compatible with it at all.