Update from Discord .Net Labs 3.4.8 #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* meta: bump version * meta: bump vers * Fix sticker args * Grammer fix (discord-net#179) * Added embeds for SendMessageAsync * [JsonProperty("embed")] forgot to remove this public Optional<Embed> Embed { get; set; } * It has been done as requested. * Changed the old way of handeling single embeds * Moved embeds param and added options param * xmls Co-authored-by: quin lynch <lynchquin@gmail.com>
* Update GuildPermissionsTests.cs * Update GuildPermissions.cs
* Used compound assignment * -||- * -||-
* Fixed some warnings * Another fixed warning * Changed the SSendFileAsync to SendFileAsync * Removed para AlwaysAcknowledgeInteractions * Moved it back to the previous version * Added periods to the end like quin requested!! :(( Co-authored-by: MrCakeSlayer <13650699+MrCakeSlayer@users.noreply.github.com>
* Use 'switch' expression * Reverted it to the old switch case
* Submitting updates to include new permissions. * Make old permissions obsolete and update tests Co-authored-by: quin lynch <lynchquin@gmail.com>
* Add support for sending files with multiple embeds * Simplify prepending single embed to embed array
* Changed the way of handling prepending of embeds. For consistency. * reformatted the summary
* Added some requirements to channels for topic * Changed check from NotNullOrEmpty to NotNullOrEmpty * Added some requirements to channels for name Preconditions.LessThan * Formatting of file
The style was not properly added to it and the plastic version does not look good with the discord badge. I thought it would look better with a logo
Co-Authored-By: Nova Fox <novamaday@gmail.com>
Changed _guildScheduledEventCancelled to _guildScheduledEventCreated in GUILD_SCHEDULED_EVENT_CREATE
…ommandOptionProperties (discord-net#339)
…ap instead of stirng[] (discord-net#342)
* Refactor Interactions * Remove ApplicationCommandException
* fix module preconditions * fix module preconditions
This comit makes `Content` optional for webhook execution. This comit also adds null checks to content when creating the api args to properly specify the optional struct to the model. This is done so the message entity doesn't try to parse a null string.
quinchs
added
priority: improvement
V3 Todo
MrCakeSlayer
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the dev branch to labs version 3.4.8.
Sending multiple files with Interactions
You can now send multiple files with interactions as followups! follows the same standard as sending multiple files in messages.
Interaction Service
@Cenngo's interaction service is added in this PR.
.NET 5.0 and .NET 6.0
All the projects have been updated to build with net5.0 and net6.0.
Changes
IApplicationCommandInteractioninterface and makeIUserCommandInteraction,IMessageCommandInteraction, andISlashCommandInteractioninherit it.RequestOptionsto the last parameter as well as changecomponenttocomponents.FollowupWithFilesAsyncto interactions to allow uploading multiple attachments.RespondAsyncreturn aRestInteractionMessagebased off of the parameters sent over to discord. This allows direct calls toModifyAsyncandDeleteAsyncwithout having to get the interaction response first.ApplicationCommandExceptionin favor forHttpException.IUser UsertoIDiscordInteraction.PRs