Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack metapackage with Discord.Net.Core version #1967

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

adamgauthier
Copy link
Contributor

@adamgauthier adamgauthier commented Dec 15, 2021

To avoid any mismatch between both versions and duplication in the code,
the .nuspec file is simplified. The build process now ensures the
version is set to the exact version Discord.Net.Core is packed with.

@quinchs
Copy link
Member

quinchs commented Dec 15, 2021

@SubZero0 Thoughts?

@adamgauthier
Copy link
Contributor Author

For context, there is currently an issue where the metapackage is packed with dependencies of format version-buildnumber instead of the actual version of the pushed dependencies (version-dev-buildnumber). This leads to errors when attempting to use the metapackage:

NU1603    Discord.Net 3.0.0-dev-20211215.1 depends on Discord.Net.Commands (>= 3.0.0-20211215.1) but Discord.Net.Commands 3.0.0-20211215.1 was not found. An approximate best match of Discord.Net.Commands 3.0.0-dev-20210524.5 was resolved.

This change would make it impossible to happen in the future (assuming all packages are in sync with Discord.Net.Core)

To avoid any mismatch between both versions and duplication in the code,
the .nuspec file is simplified. The build process now ensures the
version is set to the exact version Discord.Net.Core is packed with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants