Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAuth2 Base authorization URL #5237

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

Zoddo
Copy link
Contributor

@Zoddo Zoddo commented Jul 24, 2022

This remove a useless redirect and allows for a nicer error when an invalid scope is sent (this vs this).

The URL generator on the dev portal can also be updated to remove /api from the path.

This saves a useless redirect and allows for a nicer error when an invalid scope is sent
@ckohen
Copy link
Contributor

ckohen commented Jul 24, 2022

Think maybe there should be a note on why this is different.

Don't know if this should be part of that note, but using the /api route causes all subdomains to redirect to stable discord as well which is a huge pain in the butt when you're only logged in to canary or ptb on web.

@zeylahellyer zeylahellyer merged commit c908891 into discord:main Aug 29, 2022
@Zoddo Zoddo deleted the patch-3 branch August 29, 2022 18:43
sebm253 pushed a commit to disgoorg/disgo that referenced this pull request Aug 29, 2022
reboxer added a commit to reboxer/discord-oauth2 that referenced this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants