Update Application Endpoints #6297

shaydewael · 2023-07-13T21:59:03Z

Documents PATCH method for current applications, which allows you to update a partial set of properties via the API
Adds interactions_endpoint_url, bot, and redirect_uris to Application structure
Cleans up descriptions for Application structure

docs/resources/Application.md

Lulalaby · 2023-07-13T22:42:00Z

docs/resources/Application.md

+| terms_of_service_url?              | string                                                                     | URL of the app's Terms of Service                                                                                     |
+| privacy_policy_url?                | string                                                                     | URL of the app's Privacy Policy                                                                                       |
+| owner?                             | partial [user](#DOCS_RESOURCES_USER/user-object) object                    | Partial user object for the owner of the app                                                                          |
+| summary *(deprecated)*             | string                                                                     | **deprecated and will be removed in v11.** An empty string.                                                           |


If this is deprecated and always an empty string, maybe we can just undocument this field?

Lulalaby · 2023-07-13T22:42:44Z

docs/resources/Application.md

+| team                               | ?[team](#DOCS_TOPICS_TEAMS/data-models-team-object) object                 | If the app belongs to a team, this will be a list of the members of that team                                         |
+| guild_id?                          | snowflake                                                                  | Guild associated with the app. For example, a developer support server.                                               |
+| guild?                             | partial [guild](#DOCS_RESOURCES_GUILD/guild-object) object                 | Partial object of the associated guild                                                                                |
+| primary_sku_id?                    | snowflake                                                                  | If this app is a game sold on Discord, this field will be the id of the "Game SKU" that is created, if exists         |


"if exists" sounds weird, like the sentence didn't ended

docs/resources/Application.md

Lulalaby · 2023-07-13T22:44:09Z

docs/resources/Application.md

+| approximate_guild_count?           | integer                                                                    | Approximate count of number of guilds the app has been added to                                                       |
+| redirect_uris?                     | array of strings                                                           | Array of redirect URIs for the app                                                                                    |
+| interactions_endpoint_url?         | string                                                                     | [Interactions endpoint URL](#DOCS_INTERACTIONS_RECEIVING_AND_RESPONDING/receiving-an-interaction) for the app         |
+| role_connections_verification_url? | string                                                                     | Role connection verification URL for the app                                                                          |


Maybe link to topic?

Lulalaby · 2023-07-13T22:44:55Z

docs/resources/Application.md

+| --------------------------------- | -------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------- |
+| custom_install_url                | string                                                                     | Default custom authorization URL for the app, if enabled                                                      |
+| description                       | string                                                                     | Description of the app                                                                                        |
+| role_connections_verification_url | string                                                                     | Role connection verification URL for the app                                                                  |


Maybe link to topic?

docs/resources/Application.md

Misha-133 · 2023-07-14T11:11:05Z

docs/resources/Application.md

+| custom_install_url                | string                                                                     | Default custom authorization URL for the app, if enabled                                                      |
+| description                       | string                                                                     | Description of the app                                                                                        |
+| role_connections_verification_url | string                                                                     | Role connection verification URL for the app                                                                  |
+| install_params                    | [install params](#DOCS_RESOURCES_APPLICATION/install-params-object) object | Settings for the app's default in-app authorization link, if enabled                                          |


Suggested change

| install_params | [install params](#DOCS_RESOURCES_APPLICATION/install-params-object) object | Settings for the app's default in-app authorization link, if enabled |

| install_params | ?[install params](#DOCS_RESOURCES_APPLICATION/install-params-object) object | Settings for the app's default in-app authorization link, if enabled |

It seems that install_params can be set to null in order to remove them.

bijij · 2023-07-16T05:40:53Z

docs/resources/Application.md

+| rpc_origins?                       | array of strings                                                           | List of RPC origin URLs, if RPC is enabled                                                                            |
+| bot_public                         | boolean                                                                    | when `false`, only the app owner can add the app to guilds                                                            |
+| bot_require_code_grant             | boolean                                                                    | when `true`, the app's bot will only join upon completion of the full OAuth2 code grant flow                          |
+| bot?                               | partial [user](#DOCS_RESOURCES_USER/user-object) object                    | Partial user object for the bot user associated with the app                                                          |


Is there any chance the payload of this could be reworked to match what is returned from /users/@me?

would suggest opening an issue about this for sure (if there hasn't been one opened already).

Rapptz · 2023-07-18T23:54:25Z

This seems like a close solution to #4726. Would it be possible for that bot user to have the same keys that /users/@me has? That endpoint has verified, locale, and mfa_enabled which are missing here. Admittedly these are somewhat niche or useless but my library's ClientUser data type includes these keys.

Zoddo · 2023-09-07T17:06:55Z

docs/resources/Application.md

+| terms_of_service_url?              | string                                                                     | URL of the app's Terms of Service                                                                                     |
+| privacy_policy_url?                | string                                                                     | URL of the app's Privacy Policy                                                                                       |
+| owner?                             | partial [user](#DOCS_RESOURCES_USER/user-object) object                    | Partial user object for the owner of the app                                                                          |
+| summary *(deprecated)*             | string                                                                     | **deprecated and will be removed in v11.** An empty string.                                                           |


If this is deprecated and always an empty string, maybe we can just undocument this field?

Zoddo · 2023-09-07T17:07:54Z

docs/resources/Application.md

+| verify_key                         | string                                                                     | Hex encoded key for verification in interactions and the GameSDK's [GetTicket](#DOCS_GAME_SDK_APPLICATIONS/getticket) |
+| team                               | ?[team](#DOCS_TOPICS_TEAMS/data-models-team-object) object                 | If the app belongs to a team, this will be a list of the members of that team                                         |
+| guild_id?                          | snowflake                                                                  | Guild associated with the app. For example, a developer support server.                                               |
+| guild?                             | partial [guild](#DOCS_RESOURCES_GUILD/guild-object) object                 | Partial object of the associated guild                                                                                |


AFAIK, the guild field is only present if the support server is DISCOVERABLE. Maybe this can be mentioned here?

That's correct.

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>

See discord/discord-api-docs#6297.

…cation fields (#2284) Ref: - discord/discord-api-docs#6297 Additionally, this changes the path for `get_user_application` to be `/application/@me` instead of `/oauth2/applications/@me` for consistency. This returns the same data and shouldn't effect any users.

* update application endpoints * make bot optional * uh * add back approximate_guild_count * aaa * Update docs/resources/Application.md Co-authored-by: Lala Sabathil <aiko@aitsys.dev> * Update docs/resources/Application.md Co-authored-by: Lala Sabathil <aiko@aitsys.dev> * TABLES * tag characters --------- Co-authored-by: Lala Sabathil <aiko@aitsys.dev>

shaydewael added 5 commits July 13, 2023 14:53

update application endpoints

695b2a4

make bot optional

60eebfe

uh

23fe445

add back approximate_guild_count

228dabd

aaa

70d7e5f

Lulalaby reviewed Jul 13, 2023

View reviewed changes

Jiralite mentioned this pull request Jul 14, 2023

feat: Support new application properties and patch endpoint discordjs/discord.js#9709

Merged

Misha-133 reviewed Jul 14, 2023

View reviewed changes

docs/resources/Application.md Outdated Show resolved Hide resolved

Misha-133 reviewed Jul 14, 2023

View reviewed changes

Misha-133 mentioned this pull request Jul 14, 2023

[Feature] New ModifyCurrentApplication features discord-net/Discord.Net#2730

Merged

Panthr75 mentioned this pull request Jul 14, 2023

[Feature] New ModifyCurrentApplication features Panthr75/Based-Discord.Net#4

Merged

bijij reviewed Jul 16, 2023

View reviewed changes

sebm253 mentioned this pull request Jul 16, 2023

Update Applications disgoorg/disgo#290

Merged

Jiralite mentioned this pull request Aug 22, 2023

feat: Application patch and new properties discordjs/discord-api-types#810

Merged

Zoddo reviewed Sep 7, 2023

View reviewed changes

sebm253 mentioned this pull request Sep 15, 2023

Application: add bot field #6435

Closed

shaydewael and others added 5 commits September 28, 2023 13:41

Update docs/resources/Application.md

7354b38

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>

Update docs/resources/Application.md

3be238b

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>

Merge branch 'main' into update-application-endpoints

6139992

TABLES

811e144

tag characters

33eb268

shaydewael merged commit 0e11b77 into discord:main Sep 28, 2023
3 checks passed

shaydewael deleted the update-application-endpoints branch September 28, 2023 17:58

suneettipirneni mentioned this pull request Oct 1, 2023

feat(model, cache): Add support for application editing and new application fields twilight-rs/twilight#2284

Merged

Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Oct 29, 2023

Implement application editing.

f8c454d

See discord/discord-api-docs#6297.

Azn9 mentioned this pull request Mar 20, 2024

Add support for the Get and Edit Current Application endpoints Discord4J/Discord4J#1189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Application Endpoints #6297

Update Application Endpoints #6297

shaydewael commented Jul 13, 2023

Lulalaby Jul 13, 2023

Zoddo Sep 7, 2023

Lulalaby Jul 13, 2023

Lulalaby Jul 13, 2023

Lulalaby Jul 13, 2023

Misha-133 Jul 14, 2023

bijij Jul 16, 2023

shaydewael Sep 28, 2023

Rapptz commented Jul 18, 2023

Zoddo Sep 7, 2023

Zoddo Sep 7, 2023

Lulalaby Sep 7, 2023

	\| summary (deprecated) \| string \| deprecated and will be removed in v11. An empty string. \|
	\| summary (deprecated) \| string \| Deprecated and will be removed in v11. An empty string. \|

	\| install_params \| [install params](#DOCS_RESOURCES_APPLICATION/install-params-object) object \| Settings for the app's default in-app authorization link, if enabled \|
	\| install_params \| ?[install params](#DOCS_RESOURCES_APPLICATION/install-params-object) object \| Settings for the app's default in-app authorization link, if enabled \|

Update Application Endpoints #6297

Update Application Endpoints #6297

Conversation

shaydewael commented Jul 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rapptz commented Jul 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment