Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-colyseus example #2

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix react-colyseus example #2

merged 1 commit into from
Jan 30, 2024

Conversation

goatslacker
Copy link
Member

  • README instructions needed some tweaks
  • package.json scripts were a bit broken
  • Most importantly, fixed up the package.json versions -- there were a few version mismatches 14 vs 15.
  • Moved the dependencies into their appropriate workspace and made the root project package.json cleaner.

Example works now!

Screenshot 2024-01-26 at 1 05 09 PM

Copy link
Contributor

@matthova matthova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for running through the examples and cleaning up 🎉

@matthova matthova merged commit d548261 into main Jan 30, 2024
1 check failed
@goatslacker goatslacker deleted the goatslacker/fix-colyseus branch January 30, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants