Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate between different versions of prost-types #3

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

goakley
Copy link

@goakley goakley commented Oct 1, 2024

This is absolutely awful, but do you know what was even more awful? Trying to upgrade every prost package and all the packages that use prost under the hood.

This is absolutely awful, but do you know what was even more awful?
Trying to upgrade every prost packages and all the packages that use prost under the hood.
/// This function discards any `UninterpretedOption`s.
///
/// "Why don't you just upgrade `prost_types` to match the version used by `prost_reflect`?
/// Ha. Hahaha. Hahahahahahaha. My branches are littered with the corpses of such attempts.

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Hahaha is not a recognized word. (unrecognized-spelling)
/// This function discards any `UninterpretedOption`s.
///
/// "Why don't you just upgrade `prost_types` to match the version used by `prost_reflect`?
/// Ha. Hahaha. Hahahahahahaha. My branches are littered with the corpses of such attempts.

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Hahahahahahaha is not a recognized word. (unrecognized-spelling)
@goakley goakley marked this pull request as ready for review October 1, 2024 22:00
Copy link

@AndrooTheChen AndrooTheChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-01 at 3 09 39 PM

/// This function discards any `UninterpretedOption`s.
///
/// "Why don't you just upgrade `prost_types` to match the version used by `prost_reflect`?
/// Ha. Hahaha. Hahahahahahaha. My branches are littered with the corpses of such attempts.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My branches are littered with the corpses of such attempts.

im sorry

@goakley goakley merged commit 6968364 into master Oct 1, 2024
72 of 79 checks passed
@goakley goakley deleted the glen/convert branch October 1, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants