Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add discriminator field as string instead of number #10

Merged
merged 6 commits into from
Jun 18, 2021
Merged

fix: add discriminator field as string instead of number #10

merged 6 commits into from
Jun 18, 2021

Conversation

lumap
Copy link
Contributor

@lumap lumap commented Jun 18, 2021

:)

@ayntee ayntee changed the title fix member#tag as well as member#discriminator fix: discriminator field as string instead of number Jun 18, 2021
@ayntee ayntee changed the title fix: discriminator field as string instead of number fix: add discriminator field as string instead of number Jun 18, 2021
ayntee
ayntee approved these changes Jun 18, 2021
View reviewed changes
Copy link

@ayntee ayntee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itohatweb
Copy link
Member

Why the change from Number to String?

Lumap added 2 commits June 18, 2021 16:27
@Skillz4Killz Skillz4Killz merged commit 6718c5e into discordeno:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayntee ayntee ayntee approved these changes

@Skillz4Killz Skillz4Killz Skillz4Killz approved these changes

@itohatweb itohatweb Awaiting requested review from itohatweb itohatweb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lumap @itohatweb @Skillz4Killz @ayntee