This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
feat(Errors): show data sent when an error occurs #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from discordjs/discord.js#5701 Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 89.48% 89.83% +0.34%
==========================================
Files 8 8
Lines 1037 1072 +35
Branches 107 107
==========================================
+ Hits 928 963 +35
Misses 3 3
Partials 106 106
Continue to review full report at Codecov.
|
Perhaps we should make those take objects? 5 parameters is a bit much. |
I didn't because they are al required. Also, you can't use the shorthand for properties when destructuring, though I know that will probably want to change anyways so that it can be documented properly |
iCrawl
previously approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vladfrangu
suggested changes
Oct 18, 2021
vladfrangu
approved these changes
Oct 18, 2021
iCrawl
approved these changes
Oct 18, 2021
kyranet
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Ported from discordjs/discord.js#5701
Status and versioning classification: