refactor: use collection to store snapshots

discordjs · Sep 4, 2024 · 057e2c1 · 057e2c1
1 parent 3e6051f
commit 057e2c1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/discord.js/src/structures/Message.js b/packages/discord.js/src/structures/Message.js
@@ -452,9 +452,9 @@ class Message extends Base {
     if (data.message_snapshots) {
       /**
        * The message associated with the message reference
-       * @type {Array<Message>}
+       * @type {Collection<Snowflake, Message>}
        */
-      this.messageSnapshots = data.message_snapshots.map(snapshot => {
+      this.messageSnapshots = data.message_snapshots.reduce((coll, snapshot) => {
         const channel = this.client.channels.resolve(this.reference.channelId);
         const snapshotData = {
           ...snapshot.message,
@@ -463,10 +463,13 @@ class Message extends Base {
           guild_id: this.reference.guildId,
         };
 
-        return channel ? channel.messages._add(snapshotData) : new this.constructor(snapshotData);
-      });
+        return coll.set(
+          this.reference.messageId,
+          channel ? channel.messages._add(snapshotData) : new this.constructor(this.client, snapshotData),
+        );
+      }, new Collection());
     } else {
-      this.messageSnapshots = this.messageSnapshots?.slice() ?? [];
+      this.messageSnapshots ??= new Collection();
     }
 
     /**

diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts
@@ -2185,7 +2185,7 @@ export class Message<InGuild extends boolean = boolean> extends Base {
   public webhookId: Snowflake | null;
   public flags: Readonly<MessageFlagsBitField>;
   public reference: MessageReference | null;
-  public messageSnapshots: MessageSnapshot[];
+  public messageSnapshots: Collection<Snowflake, MessageSnapshot>;
   public awaitMessageComponent<ComponentType extends MessageComponentType>(
     options?: AwaitMessageCollectorOptionsParams<ComponentType, InGuild>,
   ): Promise<MappedInteractionTypes<InGuild>[ComponentType]>;