refactor: name approach

discordjs · Oct 11, 2024 · 154b1d8 · 154b1d8
1 parent 925398f
commit 154b1d8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/discord.js/src/managers/UserManager.js b/packages/discord.js/src/managers/UserManager.js
@@ -105,7 +105,7 @@ class UserManager extends CachedManager {
    * Flags may still be retrieved via {@link UserManager#fetch}.</warn>
    */
   async fetchFlags(user, options) {
-    emitDeprecationWarningForUserFetchFlags(true);
+    emitDeprecationWarningForUserFetchFlags(this.constructor.name);
     return (await this.fetch(user, options)).flags;
   }
 

diff --git a/packages/discord.js/src/structures/User.js b/packages/discord.js/src/structures/User.js
@@ -351,7 +351,7 @@ class User extends Base {
    * Flags may still be retrieved via {@link User#fetch}.</warn>
    */
   fetchFlags(force = false) {
-    emitDeprecationWarningForUserFetchFlags(false);
+    emitDeprecationWarningForUserFetchFlags(this.constructor.name);
     return this.client.users.fetchFlags(this.id, { force });
   }
 

diff --git a/packages/discord.js/src/util/Util.js b/packages/discord.js/src/util/Util.js
@@ -504,12 +504,11 @@ function resolveSKUId(resolvable) {
 
 /**
  * Deprecation function for fetching user flags.
- * @param {boolean} userManager Whether the class name is the user manager
+ * @param {string} name Name of the class
  * @private
  */
-function emitDeprecationWarningForUserFetchFlags(userManager) {
+function emitDeprecationWarningForUserFetchFlags(name) {
   if (deprecationEmittedForUserFetchFlags) return;
-  const name = userManager ? 'UserManager' : 'User';
   process.emitWarning(`${name}#fetchFlags() is deprecated. Use ${name}#fetch() instead.`);
   deprecationEmittedForUserFetchFlags = true;
 }